emscripten-core/emscripten

EXPORT_ES6 + proxy-to-worker produces broken code

Open

#14,164 opened on May 12, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (3,519 forks)batch import
good first bughelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (Avg merge 19d 10h) (147 merged PRs in 30d)

Description

This combination of options currently produces a Worker that contains an ES6 export, and main JS that is not an ES module. Then, main JS tries to instantiate a Worker and waits for messages from it, but they never come, since it's just exporting a lazy Module factory.

I see we emit error for regular MODULARIZE:

-s MODULARIZE=1 is not compatible with --proxy-to-worker (if you want to run in a worker with -s MODULARIZE=1, you likely want to do the worker side setup manually)

but for some reason not for EXPORT_ES6 even though one normally auto-enables another.

Contributor guide

Research direction
Locate the error message for MODULARIZE incompatibility with proxy to worker in the codebase and add a corresponding check for EXPORT ES6.
Tech stack
javascriptwasm
Domain
compilersbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++PythonEmscripten
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70