emscripten-core/emscripten

Add option to disable warnings when ASYNCIFY_REMOVE functions are not found

Open

#13,179 opened on Jan 3, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (3,519 forks)batch import
asyncifyhelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (Avg merge 19d 10h) (147 merged PRs in 30d)

Description

My project compiles a number of related apps which make slightly different calls into an ASYNCIFY using library. I've determined there are a number of functions which are safe to include in ASYNCIFY_REMOVE, but not all of the apps call all of the functions. It is a little frustrating to have to manually track for each app which functions are called and which aren't, in order to avoid the warnings Binaryen prints.

It would be nice if there was an option to disable the Binaryen warnings when an ASYNCIFY_REMOVE function is not found.

Contributor guide

Research direction
Find where the warning about ASYNCIFY REMOVE function not found is emitted in the Emscripten source code (likely in the binaryen integration). Add a new command line option like ' asyncify remove warnings' or similar to suppress that warning. Modify the relevant code to check that option before printing the warning.
Tech stack
None
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70