emscripten-core/emscripten

Data files are loaded from root, not from directory where js file is loaded from

Open

#12,288 opened on Sep 20, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (3,519 forks)batch import
good first bughelp wanted

Repository metrics

Stars
 (27,361 stars)
PR merge metrics
 (Avg merge 19d 10h) (147 merged PRs in 30d)

Description

I have a modularized wasm module that pre-js's file_packager-produced package:

/index.html (that loads dist/module.js)
/dist/module.js
/dist/module.wasm
/dist/module.data

module.wasm is indeed requested as /dist/module.wasm, but module.data is requested as /module.data, contrary to docs:

Changing the data file location
By default, the .data file containing all the preloaded files is loaded from the same URL as your .js file.

Explicit locateFile(package_name) {return '/dist/' + package_name} helped, but it would be nice if it was not needed

Contributor guide

Research direction
Investigate the default URL construction for data files in the file packager. Look at the locateFile function and how it is called. Check for a bug where the directory of the JS file is not considered when loading data files.
Tech stack
ccppjavascriptwasm
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
EmscriptenJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70