emotion-js/facepaint

Adding nested selectors at a given breakpoint

Open

#12 opened on Apr 12, 2018

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (12 forks)github user discovery
feature requesthelp wanted

Repository metrics

Stars
 (594 stars)
PR merge metrics
 (PR metrics pending)

Description

I have pseudo-selector classes that only appear at my larger breakpoint. Currently it appears that I have to put every property within them inside an array:

mq({
  '&>li:first-child': {
    background: [undefined, 'green'],
    width: [undefined, 200],
  },
})

(In practice there's many more properties in there.)

Is there any neater way I could write this, and if not could one be added? I feel like I should be able to do either:

mq({
  '&>li:first-child': [undefined,
    background: 'green',
    width: 200,
  ],
})

or

mq([undefined, {
  '&>li:first-child': {
    background: 'green',
    width: 200,
  },
}])

Contributor guide

Research direction
Study the current implementation of how breakpoint arrays are processed in the library. Look for the parsing logic that handles array values and see how to extend it to support nested object syntax for selectors at specific breakpoints.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75