emilk/egui

Remove implicit dependency on `time 0.1`

Open

#2,932 opened on Apr 19, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (29,051 stars) (2,037 forks)batch import
good first issuehelp wanted

Description

chrono, by default, depends on an old version of time, which has a RUSTSEC: https://github.com/emilk/egui/security/dependabot/7

egui doesn't use chrono, but egui_extras does as does egui_demo_lib. It would be nice to replace it with pure time 0.3 use, or use achrono without the oldtime feature it has.

It's worth noting that next release of chrono seem to have removed the dependency on time completely, so maybe this will sort itself out in time

Contributor guide

Tech stack
rust
Domain
backendsecurity
Issue type
security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustCargodependency management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining Cargo.toml files in egui extras and egui demo lib. Identify where `chrono` is used. The fix involves either disabling the `oldtime` feature of `chrono` by specifying `default features = false` or replacing `chrono` with `time 0.3`. Check the Dependabot alert for the exact security advisory. Make sure to test the changes compile and work correctly.
Remove implicit dependency on `time 0.1` · emilk/egui#2932 | Good First Issue