Grouping fails after restoring notifications
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Start in handle_restore_action and compare it with the group_notifications-related code in reapply_config, especially the referenced dbus/mako.c snippet. Verify the restore path re-applies current grouping and updates existing group members, including when a notification is deleted from a group and restored. Reproduce the configuration-change and restore steps to confirm the grouping behavior.
Written by the indexing model from the issue text.
Description
If the config has changed, new grouping rules will not be applied to notifications restored from prior to the change. Additionally, restored grouped notifications will not "update" other members of their group.
Reproduce:
- run
makowith the default (an empty) config - spawn a couple of notifications (e.g. with
notify-send test)
- close the notifications to the history (e.g. right-click)
- change the grouping config (e.g. add
group-by=app-name) - reload the config (
makoctl reload) - restore the notifications
- note: adding another notification will update them
- extra: deleting a notification from a group and then restoring it will not correctly put it back in it's group
Analysis:
handle_restore_action never calls group_notifications in any way. A similar snippet as:
https://github.com/emersion/mako/blob/c4df229e3af10bac8795afa489dcd1ee1fc7da66/dbus/mako.c#L323-L329
from reapply_config would fix.
- Dominant language
- C
- Stars
- 3.3k
- Forks
- 174
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from emersion/mako
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
High CPU usage Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
level/task module/gcp type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
-
docs
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
P3 sonic-vpp
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
sonic-net/sonic-buildimage#29662 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
spack/spack-packages#6586 ·
-
category:port-update
Difficulty 2/5 1-3 hours Newbie friendliness 72/100