Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Confirm to have tests equivalent with embulk-core

Open
  • Is something wrong?
#33 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
java, ruby
Domain
testing

Research direction

Start by comparing the unchecked Java tests in org/embulk/config/TestConfigSource.java and the Ruby tests in monkey_strptime/mri/date/test_date_strptime.rb and vanilla/time/test_timestamp_parser.rb with their referenced counterparts. Investigate which cases are equivalent or intentionally excluded, then confirm the remaining test coverage and update the checklist or tests accordingly.

Written by the indexing model from the issue text.

Description

Java src/test/java

  • org/embulk/config/TestConfigSource.java
    • Including some tests w/ TimestampParser, but just using.
  • org/embulk/spi/time/TestRubyTimeFormat.java
    • Same tests in org/embulk/util/rubytime/TestFormat.java
  • org/embulk/spi/time/TestTimeZoneIds.java
    • Most regional timezones (ex. Asia/Taipei) are not supported in embulk-util-rubytime.
    • Some are tested in org/embulk/util/rubytime/TestTimeZones.java.
    • To be tested with LegacyEmbulkZones.java on the Embulk side.
  • org/embulk/spi/time/TestTimestamp.java
    • Timestamp is Embulk's original class.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampFormatter.java
    • Formatter is not implemented yet.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampFormatterParser.java
    • It consists of tests as org.embulk.spi.Timestamp.
    • Not tested in embulk-util-rubytime.
  • org/embulk/spi/time/TestTimestampParser.java
    • These tests are to be imported.
  • org/embulk/spi/time/TestTimestampSerDe.java
    • These tests are just for SerDe.
    • Not tested in embulk-util-rubytime.

Ruby src/test/ruby

  • monkey_strptime/mri/date/test_date_strptime.rb
    • Tested with org/embulk/util/rubytime/TestRubyDateTimeFormatterParseWithJRuby.java and src/test/resources/ruby/test/date/test_date_strptime.rb
  • vanilla/test_schema.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/guess/test_schema_guess.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/guess/test_time_format_guess.rb
    • Not to be tested in embulk-util-rubytime.
  • vanilla/time/test_timestamp_parser.rb
    • Some are identical with test_date_strptime.rb, but need to be investigated.
Dominant language
Java
Stars
0
Forks
0
No merged PRs in 30d

Getting set up

We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from embulk/embulk-util-rubytime

All issues in embulk/embulk-util-rubytime

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.