Gooffiness with change detection

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
github-actions, javascript
Domain
ci-cd

Research direction

Start with the linked GitHub Actions run for PR 907 and inspect the automation that determines changed files. Reproduce the report that many files changed, then compare it with a rebased or main-merged PR. Done means change detection compares the PR with its upstream parent and reports only the actual changes.

Written by the indexing model from the issue text.

Description

Discovered here in this build: https://github.com/emberjs/rfcs/actions/runs/4883067241/jobs/8713927566?pr=907

For some reason it is coming up as all these files have changed 
(long list of files)

A work-around is rebasing (or merging main in to the PR) -- which means that the automation here may be comparing the changes from the PR to current main rather than the PR's upstream parent

Dominant language
JavaScript
Stars
0
Forks
4
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from emberjs/rfcs-tooling

All issues in emberjs/rfcs-tooling

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.