emberjs/ember.js

[Tests] Improve test suite coverage for Routing

Open

#19,609 opened on Jun 25, 2021

View on GitHub
 (9 comments) (2 reactions) (0 assignees)JavaScript (22,437 stars) (4,216 forks)batch import
Good for New ContributorsHelp Wanted

Description

The goal of this issue is to write some new tests or modify existing tests to improve coverage. There have been a series of routing bugs that may be related, and improved test coverage may have been able to prevent them. Multiple people can help work on this issue - just comment with what you are working on, and be sure to read through other people's comments.

To do:

  • read through some of the issues below
  • Write a test to help cover one of the problem areas

Past bug reports/issues:

Contributor guide

Tech stack
javascript
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Ember.js testingBasic knowledge of routing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Review the linked bug reports to identify a specific routing issue not covered by existing tests. Then write a test that reproduces the bug or validates expected behavior. Ensure the test follows Ember.js testing conventions and integrates with the existing test suite.