emberjs/ember.js

Unreachable code "reached" when trying to render a non-string with the component helper

Closed

#18,072 opened on Jun 4, 2019

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,216 forks)batch import
BugGood for New ContributorsHas ReproductionHelp Wanted

Repository metrics

Stars
 (22,437 stars)
PR merge metrics
 (Avg merge 11d 14h) (20 merged PRs in 30d)

Description

Ember Twiddle

Ember Twiddle doesn't let me go above 3.4, but I'm reproducing this on a 3.10 app (during a migration from 2.18).

This is less of a bug and more of something that could have a helpful debug assertion. Maybe something like:

You passed [Object object] to the {{component}} helper, but the component helper only accepts strings or other components.

Along with maybe a log of what that object was.

(This might not be the right repo for this, since it seems to deal with glimmervm internals)

Contributor guide

Research direction
Look at the {{component}} helper implementation in Ember.js source code. Identify where non string values are passed and add a debug assertion to warn when a non string (non component) is passed.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70