emberjs/ember.js

Splattributes, {{action}} modifier and component event handlers

Open

#17877 opened on Apr 7, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (22,437 stars) (4,216 forks)batch import
DocumentationHelp Wanted

Description

See https://github.com/emberjs/ember.js/pull/17874#discussion_r272809665

As part of the fix we need to decide which one fires first, since it was not specified in the RFC. My gut feeling is that the component’s handler should fire first and given the option to cancel it.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of Ember.js componentsFamiliarity with Ember's RFC process
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Review the discussion at https://github.com/emberjs/ember.js/pull/17874#discussion r272809665 to understand the context. Determine the order of event firing between component handlers and the {{action}} modifier. The decision should align with past RFCs and existing behavior. There is no clear resolution in the comments, so further reasoning is needed.