emberjs/ember.js

Router Service: Behaves differently in engine context regarding route path

Open

#17,014 opened on Sep 28, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (22,437 stars) (4,216 forks)batch import
BugHelp WantedRouting

Description

Hey there,

it seems like the router services behaves differently in an engine context compared to {{#link-to}} in views and transitionTo routes.

Example: I want to link to my engine's route called 'overview'. The engine is mounted as 'engine'.

This is the expected and documented behavior: Route: this.transitionTo('overview') Views: {{#link-to 'overview'}}Link{{/link-to}}

Whereas the service requires the mount point additionally: Service: this.routerService.transitionTo('engine.overview')

I think all three ways should require the same route path.

Versions:

  • ember-source: ~3.2.0
  • ember-engines: ~0.5.4

Hopefully, there's no other issue like that, but haven't found any while searching. Thanks!

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Ember.js basicsEmber Engines concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the router service implementation in ember.js, likely in packages/@ember/routing/lib/router service.js. Compare the behavior of transitionTo in the service vs link to helper and transitionTo on the route. The issue indicates that in an engine context, the service requires the mount point prefix (e.g., 'engine.overview') while other methods do not. Look at how the router service resolves routes relative to the engine's mount point. Check if there is a normalization step missing or if the service should use the engine's root URL. Review any existing tests for router service in engine context under packages/@ember/routing/tests/.
Router Service: Behaves differently in engine context regarding route path · emberjs/ember.js#17014 | Good First Issue