emberjs/ember.js

Router Service: Behaves differently in engine context regarding route path

Open

#17,014 opened on Sep 28, 2018

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)JavaScript (4,216 forks)batch import
Routingbuggood first issue

Repository metrics

Stars
 (22,437 stars)
PR merge metrics
 (Avg merge 11d 14h) (20 merged PRs in 30d)

Description

Hey there,

it seems like the router services behaves differently in an engine context compared to {{#link-to}} in views and transitionTo routes.

Example: I want to link to my engine's route called 'overview'. The engine is mounted as 'engine'.

This is the expected and documented behavior: Route: this.transitionTo('overview') Views: {{#link-to 'overview'}}Link{{/link-to}}

Whereas the service requires the mount point additionally: Service: this.routerService.transitionTo('engine.overview')

I think all three ways should require the same route path.

Versions:

  • ember-source: ~3.2.0
  • ember-engines: ~0.5.4

Hopefully, there's no other issue like that, but haven't found any while searching. Thanks!

Contributor guide

Research direction
Inspect the router service's transitionTo method in engine context and compare with link to and transitionTo usage in routes and views.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75