did-insert not triggering re-render for tracked changes

Open
#20 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
38/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Start at addon/modifiers/did-insert.js#L29 and compare its installModifier call with the changes discussed in pull request #16. Reproduce the commented example where this.count changes, then verify that the template re-renders when the tracked value changes.

Written by the indexing model from the issue text.

Description

e.g. in the example given in the code comments, the this.count is not updated in the template...

https://github.com/emberjs/ember-render-modifiers/blob/master/addon/modifiers/did-insert.js#L29

in the callstack i see that installModifier is called with a untrack context

probably because of this:
https://github.com/emberjs/ember-render-modifiers/pull/16
?

Dominant language
TypeScript
Stars
86
Forks
34
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from emberjs/ember-render-modifiers

All issues in emberjs/ember-render-modifiers

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.