Some internal links lead to server error pages

Open
#613 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
documentation

Research direction

Start by reproducing the broken links from the Ember 3.9 Location page and compare them with the corresponding 2.16 page. Trace how the API documentation viewer builds these relative URLs and identify where the extra /api segment is introduced. Done means the affected links resolve to the correct documentation pages across the reported versions.

Written by the indexing model from the issue text.

Description

🐞bug

I was looking at the page https://api.emberjs.com/ember/3.9/classes/Location, and when attempting to click on one of the links within the page resulting in the following server error:
Cannot GET /api/ember/release/classes/HashLocation

Screen Shot 2019-04-27 at 12 18 11 AM

The main issue being that the relative path defined in the ember.js repository is pointing to /api/ember/... instead of /ember/.... Removing the /api portion of the URL takes me to the correct location.

I have found that the issue on this particular page goes as far back as 2.16. Which, for the same link, gives the error Cannot GET /api/classes/Ember.Location.HashLocation.

Screen Shot 2019-04-27 at 12 28 49 AM

Again, removing the /api portion of the 2.16 URL does redirect me to the correct page on the current release.

There is the potential for an issue to be opened up on the ember.js repo to update the relative links within the documentation for the current release going forward, but figured I'd start here first.

Dominant language
JavaScript
Stars
75
Forks
111
Avg merge
45m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-learn/ember-api-docs

All issues in ember-learn/ember-api-docs

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.