Many RSVP "Defined in" links are broken for 2.18 and 3.0 API docs

Open
#487 2 comments 0 reactions 1 assignee View on GitHub

@toddjordan is already working on this.

Since Apr 11, 2018.

Assessment

This issue has not been assessed yet.

Description

🐞bug 🔙 Needs Backport

On the pages https://emberjs.com/api/ember/2.18/functions/rsvp/race and https://emberjs.com/api/ember/3.0/functions/rsvp/race, the "Defined in" links are broken.

They currently point to https://github.com/emberjs/ember.js/tree/v2.18.2/node_modules/rsvp/lib/rsvp/race.js#L3 and https://github.com/emberjs/ember.js/tree/v3.0.0/node_modules/rsvp/lib/rsvp/race.js#L3, respectively, but these give 404s when visited.

It's not just the race.js source links that are broken... other RSVP source links also give 404s when visited.

The only reason I wanted to find the source is that there's no documentation about the method at all, other that saying that it's "a convenient alias for RSVP.Promise.race - and yet if I go to the RSVP.Promise docs (at https://emberjs.com/api/ember/2.18/classes/Promise or https://emberjs.com/api/ember/3.0/classes/Promise respectively), I see no methods defined other than catch, finally, and then. The "Defined in" links on those two pages are also broken.

Dominant language
JavaScript
Stars
75
Forks
111
Avg merge
45m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-learn/ember-api-docs

All issues in ember-learn/ember-api-docs

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.