ember-fastboot/ember-cli-fastboot

Figure out why some tests need application-template-wrapper enabled to pass

Open

#838 opened on Jun 21, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (853 stars) (163 forks)batch import
Good for New Contributorsgood first issuetest

Description

As part of my work to upgrade ember-cli-fastboot using ember-cli-update I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in this commit and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

Contributor guide

Tech stack
javascript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Ember.jsFastBootTesting with QUnit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
First, revert the commit mentioned (b7c3934) to see which tests fail. Then examine the test selectors that may rely on the application template wrapper div. Look for tests that use selectors like '#ember testing' or similar. Check if the failing tests can be fixed by updating selectors or by enabling the wrapper. Report findings in the issue.