[Suggestion] Deprecate `npmOptions` and `buildManagerOptions` options in favor of a single `packageManagerInstallOptions` option

Open
#1,047 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
tooling

Research direction

Search the repository for npmOptions and buildManagerOptions, then trace how package-manager options are assembled. Verify the requested packageManagerInstallOptions type and its array-versus-function behavior, and identify the deprecation path and tests needed before considering the change complete.

Written by the indexing model from the issue text.

Description

enhancement

packageManagerInstallOptions is more in line with the new packageManager option.

packageManagerInstallOptions type:

packageManagerInstallOptions: string[] | (defaultOptions: string[], scenario: Scenario) => string[];

When the user provides string[], we don't include the default options like we do now. If the user wants to make sure the default options are included as well, they must provide a function and spread in the default options manually.

Dominant language
JavaScript
Stars
180
Forks
57
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-cli/ember-try

All issues in ember-cli/ember-try

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.