What should happen when failure to load a module?

Open
#39 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
testing

Research direction

Start at addon-test-support/index.js around line 71 and trace how errors from requiring a test file are logged and how loading proceeds. Before changing code, establish the intended failure behavior; done means the decision is documented or implemented and the missing-test scenario is covered by the repository's tests.

Written by the indexing model from the issue text.

Description

Currently, when requiring a test file, if an error gets throw, the error is logged by console.error() and the test-loader will continue to require the next test file.
See https://github.com/ember-cli/ember-cli-test-loader/blob/master/addon-test-support/index.js#L71

This effectively ignores all the tests that are part of the test file that did not get required, which would cause unexpected missing test coverage.

Was interested in knowing what is the rational in the choice of the current implementation.
@rwjblue would you have some context on this?

Dominant language
JavaScript
Stars
10
Forks
20
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-cli/ember-cli-test-loader

All issues in ember-cli/ember-cli-test-loader

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.