Update `templateOnly` compilation to pass the source moduleName as the first argument.

Open
#641 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
build-system

Research direction

Start with node-tests/colocated-broccoli-plugin-test.js around lines 46-54 and trace the templateOnly() compilation entry point it exercises. Confirm the source moduleName is passed as the first argument, then update or add coverage so the test verifies that behavior.

Written by the indexing model from the issue text.

Description

Discovered while reviewing another PR with @pzuraq, we should be passing the source moduleName in to templateOnly().

For example:

https://github.com/ember-cli/ember-cli-htmlbars/blob/fb0b18a2fd96b3375ae7f21cb85815709dc8f6f8/node-tests/colocated-broccoli-plugin-test.js#L46-L54

Dominant language
JavaScript
Stars
77
Forks
65
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-cli/ember-cli-htmlbars

All issues in ember-cli/ember-cli-htmlbars

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.