node-resolve seems unneeded
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- cli
Research direction
Review commit e7fa68cbadd6e43ca603a828b1799c3e6fd0de5d and locate the added node-resolve dependency and resolve.sync call using { basedir: __dirname }. Replace the redundant resolution approach with require.resolve and remove the unused resolve dependency, then run the repository’s existing checks to verify the change.
Written by the indexing model from the issue text.
Description
https://github.com/ember-cli/create-ember-app/commit/e7fa68cbadd6e43ca603a828b1799c3e6fd0de5d introduces node-resolve but i believe it is not needed.
require.resolve is already relative to the current file, so the { basedir: __dirname } passed to resolve.sync seems to be redundant, and can simply become require.resolve with no extra resolve dep.
- Dominant language
- JavaScript
- Stars
- 5
- Forks
- 2
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·