Respect outputPaths in ember-cli-build
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- build-system
Research direction
Start with the plugin code that builds index.json and compare its generated asset paths with the outputPaths configuration shown in ember-cli-build.js. Use config/deploy.js and the sample index.json as references, then run ember deploy production to verify that the generated link and script paths honor the configured outputPaths.
Written by the indexing model from the issue text.
Description
I recently implemented this addon and noticed that the index.json output does not respect the outputPaths config setting in ember-cli-build.js. Here is a sample of my configuration and the resulting index.json output from ember deploy production:
// ember-cli-build.js
const isProduction = ( process.env.EMBER_ENV || 'development' ) === 'production';
const assetPath = isProduction ? '' : '/assets';
module.exports = function(defaults) {
var app = new EmberApp(defaults, {
outputPaths: {
app: {
html: 'index.html',
css: {
'app': assetPath + '/app.css'
},
js: assetPath + '/app.js'
},
vendor: {
css: assetPath + '/vendor.css',
js: assetPath + '/vendor.js'
}
}
});
}
// config/deploy.js
var ENV = {
build: {},
'json-config': {
jsonBlueprint(context, pluginHelper) {
var jsonBlueprint = pluginHelper.readConfigDefault('jsonBlueprint');
jsonBlueprint.script.includeContent = true;
return jsonBlueprint;
}
}
};
// index.json
{
"base": [],
"meta": [],
"link": [{
"rel": "stylesheet",
"href": "assets/vendor-13455b8fd285c046141dd54ae73890f8.css"
}, {
"rel": "stylesheet",
"href": "assets/app-efe517a8fe179e4392e64c2a9ce8fe05.css"
}],
"script": [{
"src": "assets/vendor-127d2a9b59896b5ddff4de18193179cb.js"
}, {
"src": "assets/app-774827c1c48acfbdb034cbc16d3f5fb7.js"
}]
}
- Dominant language
- JavaScript
- Stars
- 17
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ember-cli-deploy/ember-cli-deploy-json-config
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
ember-cli-deploy/ember-cli-deploy-json-config#30 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 45/100
ember-cli-deploy/ember-cli-deploy-json-config#27 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 55/100
ember-cli-deploy/ember-cli-deploy-json-config#23 · 1 comment · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
ember-cli-deploy/ember-cli-deploy-json-config#20 · 3 comments ·
All issues in ember-cli-deploy/ember-cli-deploy-json-config
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
mksglu/context-mode#1200 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
neondatabase/website#5944 ·
-
module: core
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
bigbluebutton/bigbluebutton#25849 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jaegertracing/jaeger-ui#4506 ·