include environment in default outputPath

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript
Domain
build-system, devops

Research direction

Start by tracing how the default outputPath is defined and how the EMBER_CLI_DEPLOY_REUSE_BUILD section uses it. Determine how a dynamic environment-based default should interact with customised outputPath values and concurrent deployments; done means the behavior is specified and covered for both default and customised paths.

Written by the indexing model from the issue text.

Description

We are testing concurrent deployments using threads. We are doing this locally, but I figured it might make sense as the default:

outputPath: `tmp/deploy-dist-${environment}`

I started making a PR, but since the environment is dynamic and the defaults are defined as static, I couldn't figure out how to get it to work, especially with the EMBER_CLI_DEPLOY_REUSE_BUILD section. Also, how would you detect if someone already customised the outputPath before appending the environment?

Dominant language
JavaScript
Stars
23
Forks
23
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ember-cli-deploy/ember-cli-deploy-build

All issues in ember-cli-deploy/ember-cli-deploy-build

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.