Add Documentation to Help Contributors

Open
#459 1 comment 3 reactions 2 assignees View on GitHub

@zonuexe is already working on this.

Since Apr 14, 2018.

Assessment

This issue has not been assessed yet.

Description

Documentation Low Priority Question

@zonuexe

Based on some recent comments I've read in issues and pull-requests, how do you feel about adding a document specifically for programmers who want to contribute to PHP Mode? The document would describe things like:

  • Any code standards you want people to follow.
  • A descrption of a useful workflow, e.g.:
    ** Creating a branch with a useful name and types of names to avoid, like ejmr/bugfixes.
    ** Sanity checks to run before opening a pull-request, like running the test suite.
    ** On that topic: notes about using and (maybe more important in my opinion) expanding the test suite for all new features.
    ** How to seek peer-review for any non-trivial, non-tiny submissions.
  • Practices to follow for writing documentation.
  • And practices for writing good Git commit messages, with stuff like:
    ** Referencing previous commits when appropriate, especially for bug fixes.
    ** Including useful metadata in commit messages such as links to relevant GitHub issues.

If you believe this would be useful then I would be glad to write such a document, or at the very least contribute, on weekends where I have the energy to do so.

Dominant language
Emacs Lisp
Stars
602
Forks
117
Avg merge
12h 54m
Merged PRs (30d)
3

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from emacs-php/php-mode

All issues in emacs-php/php-mode

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.