dotenv-safe instead of manual checking a hardcodet whitelist

Open
#111 1 comment 3 reactions 1 assignee View on GitHub

@vpanjganj is already working on this.

Since Nov 22, 2018.

Assessment

This issue has not been assessed yet.

Description

suggestion

Instead of:
https://github.com/wearehive/project-guidelines/blob/4baf60bab3fc3d4616712b04f3dab48a3774d20c/config.sample.js#L1-L9

Maybe its an idea to use dotenv-safe, with that you can define the needed env variables in the .env.example (the optional ones can be prefixed with # ).

Dominant language
JavaScript
Stars
29.4k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from elsewhencode/project-guidelines

All issues in elsewhencode/project-guidelines

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.