elsa-workflows/elsa-core

IUserTaskService enhancement - optional activityId

Open

#4,535 opened on Oct 13, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (979 forks)batch import
bugelsa 2elsa 3enhancementgood first issuetriaged

Repository metrics

Stars
 (5,486 stars)
PR merge metrics
 (Avg merge 1d 17h) (29 merged PRs in 30d)

Description

The IUserTaskService is great but, I think it needs an improvement.

Specifically, i think the TriggerUserAction record needs an optional activityId, to be absolutely specific if the action being performed is going to target the correct activity.

public record TriggerUserAction(string Action,string? WorkflowInstanceId = default,string? CorrelationId = default );

to become

public record TriggerUserAction(string Action,string? WorkflowInstanceId = default, string? ActivityId = default, string? CorrelationId = default );

If you consider the possibility that a Fork has a blocking activity on each branch, and each perhaps has the same outcome names, then the specificity requires in that use providing the activityId.

This change would also predicate the IUserTaskService needing two additional methods:

        Task< CollectedWorkflow> ExecuteUserActionAsync(TriggerUserAction taskAction, CancellationToken cancellationToken = default(CancellationToken));

        Task<CollectedWorkflow> DispatchUserActionAsync(TriggerUserAction taskAction, CancellationToken cancellationToken = default(CancellationToken));

Contributor guide