Inconsistent use of 'uri' and 'url' in example/main.cpp

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
cli

Research direction

Open example/main.cpp and inspect the --help text, argument parser, and missing-argument error around the lines mentioned in the issue. Make the option name consistent across all three locations, then run the example with --help and the affected argument forms to confirm parsing and error output agree.

Written by the indexing model from the issue text.

Description

The --help option in line 25 lists --url as a possible argument

std::cout << "example --url <url> [--protocol <protocol>] [--method <method>] [--arguments <arguments>] [--output <output>]\n";

but the argument parsing in line 28 expects --uri

else if (arg == "--uri")

and complains "Missing argument for --url" in line 31

else throw std::runtime_error("Missing argument for --url");
Dominant language
C++
Stars
969
Forks
200
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from elnormous/HTTPRequest

All issues in elnormous/HTTPRequest

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.