eligrey/FileSaver.js

saveAs not used. Throws server error on download

Open

#525 opened on Feb 14, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (21,193 stars) (4,366 forks)batch import
Make a Blobhelp wanted

Description

Not sure why I am getting a server error on download. I am working in React. The way I have this written it says, "saveAs is declared but not used. No unused vars" as a warning in the console. When I fire the click handler it attempts to download, but throws an error.

import FileSaver, { saveAs } from 'file-saver'

 handleClick = (event) => {
        console.log("this.newOrder = ", this.newOrder)
        const csv = Papa.unparse(this.newOrder) 
        console.log("csv = ", csv)
        FileSaver.saveAs(csv)
    }

_Uncaught TypeError: Cannot read property 'name' of undefined
    at Function.a [as saveAs] (FileSaver.min.js:47)
    at App._this.handleClick (App.js:85)
    at Button.onClick (reactstrap.es.js:1115)
    at HTMLUnknownElement.callCallback (react-dom.development.js:147) etc etc_

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptUnderstanding of Blob API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is that the user is calling FileSaver.saveAs with a CSV string, but the API expects a Blob or file URL. To fix, the user should convert the CSV string to a Blob using `new Blob([csv], {type: 'text/csv;charset=utf 8'})` and then call `saveAs(blob, 'filename.csv')`. Additionally, the import of `saveAs` is unused and can be removed or used properly. The error occurs because the library tries to read the 'name' property of the undefined second argument. The maintainers should clarify the API or improve error messages.