element-hq/element-android

Input bar doesn't focus when editing message

Open

#8,502 opened on Jun 4, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Kotlin (912 forks)auto 404
A-ComposerO-OccasionalS-MinorT-Defecthelp wanted

Repository metrics

Stars
 (3,713 stars)
PR merge metrics
 (PR metrics pending)

Description

Steps to reproduce

In a room, edit one of your own messages by long-pressing and tapping "Edit".

Outcome

What did you expect?

I expected the virtual keyboard to pop up (by focusing the input bar at the bottom of the screen). Surely, the only sensible thing to do after tapping "Edit" is to actually type something (or cancel, of course).

What happened instead?

The keyboard did not pop up, even if the input bar was focused before the long-press action. (The opening of the context menu unfocuses the input bar and removes the keyboard from the screen.)

Your phone model

Oneplus 6T

Operating system version

Android 11 (oxygenos 11.1.2.2)

Application version and app store

Element 1.5.32 [40105320] (F-8dcb5f70) (from Fdroid), olm 3.2.12

Homeserver

Conduit

Will you send logs?

No

Are you willing to provide a PR?

No

Contributor guide

Research direction
Investigate the message editing flow: locate where the edit action is handled and ensure the input bar requests focus when the edit mode begins. Check if the context menu or long press action interrupts focus.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidKotlinGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75