element-hq/element-android

Create booleans to configure preferences (settings screens) easily

Open

#5,366 opened on Feb 25, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Kotlin (912 forks)auto 404
A-Settingshelp wanted

Repository metrics

Stars
 (3,713 stars)
PR merge metrics
 (PR metrics pending)

Description

Create a set of booleans to configure preferences screens easily. It also has the advantage to centralize the default value for each setting. Before 2 boolean values had to be changed to change the default value of a preference (one in the XML and one in the file VectorPreferences.kt).

There is now a boolean to show or hide the setting in the preference screen, and a boolean for the default value of the preference.

It has been done for the root preference screen and the message bubbles: see here and the PR #5157 for more details.

Now we should do it for every single preference, which is, let's be honest, a boring and fastidious work.

If anyone in the community wants to give us a hand, it will be appreciated. It can of course be split into several small PRs (say one PR per preference screen). Every small PR will be appreciated!

Contributor guide

Research direction
Review the existing config settings.xml and VectorPreferences.kt to understand the boolean pattern used for the root preference screen and message bubbles (PR #5157), then replicate it across all preference screens. Start with a single screen to keep the PR small.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitKotlinAndroidXML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75