Crash on Application Boot

Open
#103 3 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
electron, typescript
Domain
desktop

Research direction

Start with app/updater.js around line 37 and the @electron/remote renderer paths in remote.js, especially metaToValue and getBuiltin. Reproduce the renderer-process boot failure and compare the null sendSync behavior with electron/electron#31733; done means identifying and validating a fix for the intermittent null response.

Written by the indexing model from the issue text.

Description

2021/12/28 15:30:11:334 TypeError: Cannot read properties of null (reading 'type')
    at metaToValue (C:\Program Files\Badlion Client\resources\app.asar\node_modules\@electron\remote\dist\src\renderer\remote.js:250:14)
    at Object.getBuiltin (C:\Program Files\Badlion Client\resources\app.asar\node_modules\@electron\remote\dist\src\renderer\remote.js:360:12)
    at Object.get [as app] (C:\Program Files\Badlion Client\resources\app.asar\node_modules\@electron\remote\dist\src\renderer\remote.js:398:28)
    at Object.get [as app] (C:\Program Files\Badlion Client\resources\app.asar\node_modules\@electron\remote\dist\src\renderer\index.js:4:80)
    at file:///C:/Program%20Files/Badlion%20Client/resources/app.asar/app/updater.js:37:38
    at file:///C:/Program%20Files/Badlion%20Client/resources/app.asar/app/updater.js:66:2

Electron 15.3.4 is being used, also tried 16.0.5 and got the same issue.
It's erroring out on this line:

import remote from '@electron/remote';
...
let { app } = remote; // errors out on this line

This is being called in the renderer process.

This appears to be some kind of race condition that only a very few number of users seem to have. We have seen several of these different stack traces for various areas in the remote module. We have also seen sendSync return null for some users (did a band aid for this one) in our own code....which seems to be the same issue that is happening here in the electron/remote code directly itself too in the metaToValue function call.

Looking for some advice/help here as to how to get this fixed. Like mentioned above, the main culprit is sendSync returning null.

More details about the sendSync error can be found here https://github.com/electron/electron/issues/31733.

Dominant language
TypeScript
Stars
411
Forks
53
Avg merge
3m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from electron/remote

All issues in electron/remote

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.