Cation adds api-review/requested when PR is labeled with api-review/reviewed

Open
#155 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
github, typescript
Domain
tooling

Research direction

Use electron/electron#40301 as the reproduction case and trace Cation's handling of the api-review/requested and api-review/reviewed labels. Confirm that applying api-review/reviewed does not cause api-review/requested to be re-added, while preserving the intended notification behavior.

Written by the indexing model from the issue text.

Description

This PR illustrates the problem: https://github.com/electron/electron/pull/40301

When an API WG member has reviewed a PR and added feedback, I think we're supposed to add the api-review/reviewed label and remove the api-review/requested label. However, when we do that it looks like Cation automatically adds back the api-review/requested label (which triggers API WG notifications about a new PR).

If I'm understanding our API WG labeling system correctly, Cation should only be adding the api-review/requested label if no other api-review label (including api-review/reviewed) has been applied.

Dominant language
TypeScript
Stars
21
Forks
20
Avg merge
33m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from electron/cation

All issues in electron/cation

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.