min and max aggregate functions ignore multiplicity

Open
#88 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
stream-processing

Research direction

Locate the min and max aggregate implementations and compare them with the avg, median, and mode operators described in the issue. Confirm how multiplicities of -1 are handled, then update min and max so removed stream entries affect the result and verify that existing aggregate behavior remains correct.

Written by the indexing model from the issue text.

Description

Min and Max functions appear to find the min/max value of all values that ever existed in the stream, regardless of multiplicity. To me, this doesn't seem like the desired behavior. On the other hand, the other aggregate statistical operators (avg, median and mode) all appear to account for stream entries being 'removed' by reversing the aggregation for multiplicities of -1.

Dominant language
TypeScript
Stars
563
Forks
12
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from electric-sql/d2ts

All issues in electric-sql/d2ts

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.