electerious/ackee-lighthouse

Add .env property to allow to set more Browser flags

Open

#10 opened on Jul 23, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3 forks)github user discovery
help wanted

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

I used the tool locally and I missed the following feature to set a custom browser path:

const createReports = async (endpoint, headers, events, urls, audit) => {
    const additionalBrowserFlags = {};
    if (process.env.BROWSER_PATH)
        additionalBrowserFlags['chromePath'] = process.env.BROWSER_PATH;

    const browser = await chromeLauncher.launch({
        chromeFlags: ['--headless'],
        ...additionalBrowserFlags,
    });
    ...
}

.env file:

...
BROWSER_PATH=C:\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe
...

A such configuration would allow to test with multiple Chromium based browser like in my case Edge. What do you think? Would that be a proper enhancement?

Contributor guide

Research direction
Explore using dotenv to load BROWSER PATH from .env and pass it as chromePath option to chromeLauncher.launch(). Consider fallback behavior and documentation updates.
Tech stack
javascriptnodejs
Domain
backendtooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70