elastic/logstash

Support Locale for date parsing in sprintf format

Open

#2,315 opened on Jan 5, 2015

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Ruby (3,496 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (14,197 stars)
PR merge metrics
 (Avg merge 4d 19h) (50 merged PRs in 30d)

Description

When parsing a date with sprintf, we use by default the local Locale.

For example:

 mutate {
    replace => { "message" => "%{start}[%{+dd/MMM/YYYY:HH:mm:ss Z}]%{end}" }
  }

could produce something different when running on a french computer than on an english computer: 14/déc./2014:00:13:42 +0000 vs 14/Dec/2014:00:13:42 +0000.

It could be nice to specify for a date the Locale we want to use whatever is set on the computer.

%{+LOCALE@DATE_FORMAT} such as:

 mutate {
    replace => { "message" => "%{start}[%{+fr@dd/MMM/YYYY:HH:mm:ss Z}]%{end}" }
  }

Contributor guide

Research direction
Inspect how Logstash handles the sprintf date format and find where the default locale is applied. Add logic to parse a locale prefix (e.g., fr@) from the format string and use it for date parsing.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65