elastic/kibana

Remove `export *` pattern from Data plugin

Open

#99,515 opened on May 6, 2021

View on GitHub
 (6 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:SearchTeam:DataDiscoverygood first issueimpact:mediumloe:smalltechnical debt

Description

export * makes it easy for a developer to accidentally expose functionality on a plugin's public API, and so should be avoided in favor of explicit exports.

Looks like data/common/index.ts has quite a few: https://github.com/elastic/kibana/blob/master/src/plugins/data/common/index.ts#L9

Contributor guide

Tech stack
typescript
Domain
data
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
TypeScript basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Locate all `export *` statements in src/plugins/data/common/index.ts and replace them with explicit named exports. Confirm that each exported module is listed individually to avoid accidental exposure. Optionally, scan the rest of the data plugin for similar patterns to ensure consistency.