elastic/kibana

[Snapshot Restore] Disable navigation via step name when the form is invalid

Open

#99,041 opened on May 3, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Snapshot and RestoreTeam:Kibana Managementbuggood first issuepapercut

Description

Relates to #95876 fixed by PR#95939.

When a step (index settings) is invalid, it's possible to navigate to the previous step (logistics) by clicking its name in the wizard top navigation bar. That way the wizard will be blocked on the 1st step with a disabled 'next' button.

https://user-images.githubusercontent.com/6585477/116881324-6ac41400-ac23-11eb-8721-6df3210ca2d3.mp4

To reproduce:

  1. start ES with a folder for snapshots by adding -E path.repo=/tmp/es-snaps to your ES start command
  2. create a snapshot repository and a policy
  3. run the policy
  4. navigate to snapshots list and try to restore a snapshot
  5. in the wizard navigate to 'index settings' step
  6. enable "Modify index settings" to introduce a form error
  7. navigate to the previous step by clicking 'Logistics' in the top navigation bar

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactKibana plugin developmentForm validation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue involves the snapshot restore wizard in Kibana. Look at the wizard component responsible for step navigation, likely in `x pack/plugins/snapshot restore/` directory. The previous fix in PR#95939 addressed a similar issue but did not prevent navigation via clicking step names. Investigate how the step names are rendered and ensure they are disabled when the form is invalid. Check the form validation state and propagate it to the navigation bar.