elastic/kibana

[APM] Annotations: Service version label could be better

Open

#66,138 opened on May 11, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Team:obs-ux-infra_services - DEPRECATEDenhancementgood first issueneeds-refinementstale

Description

I'm not really sure what to call this issue. I've been playing around with the annotations API, and I'm wondering if we should reconsider the "Service version" graph label and "Version" key in the popup:

When annotations are derived from a change in service.version, this makes sense, but with custom labels on annotations, it might make more sense to remove the "Version" key, and change the "Service version" label to something else.

Contributor guide

Tech stack
typescriptreact
Domain
frontendobservability
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with APM annotationsbasic knowledge of Kibana UI components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Look for the APM annotations component in the Kibana codebase. The issue references the 'Service version' label and 'Version' key in the popup. Locate the relevant file, likely in the APM plugin under x pack/plugins/apm, and modify the string. Ensure the change aligns with the desired behavior described in the issue. The discussion in the comments may provide additional context.
[APM] Annotations: Service version label could be better · elastic/kibana#66138 | Good First Issue