elastic/kibana

[SR] App to use moment for formatting table dates

Open

#57,198 opened on Feb 10, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Snapshot and RestoreTeam:Kibana Managementbuggood first issuepapercut

Description

The i18n component FormattedDateTime does not use the ui settings to format dates. It depends on the set i18n.locale setting for its formatting display.

We usually recommend using that for formatting relative time and some other cases. As for the SR table I think it is better to use moment formatting that adheres to the ui setting for date formatting.

image

Related PR: https://github.com/elastic/kibana/pull/40925

Contributor guide

Tech stack
typescriptreact
Domain
frontendinternationalization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Kibana's i18n systemBasic knowledge of moment.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Locate the FormattedDateTime component in Kibana's codebase. Review the linked PR #40925 to understand the previous approach and the desired use of moment for date formatting. Examine how ui settings for date formatting are accessed, then modify the component to use moment with those settings.