elastic/kibana

Expand feature registry validation test coverage

Open

#207,342 opened on Jan 21, 2025

View on GitHub
 (6 comments) (0 reactions) (1 assignee)TypeScript (8,021 forks)batch import
Team:Coregood first issue

Repository metrics

Stars
 (19,065 stars)
PR merge metrics
 (Avg merge 1d 16h) (999 merged PRs in 30d)

Description

In https://github.com/elastic/kibana/pull/202863#discussion_r1923664248 the registry had to be changed to accommodate replacing disabled privileges with disabled privileges, but this surfaced the fact that the existing test cases miss coverage for the following privilege replacement scenarios:

  • Disabled → Disabled privilege replacement
  • Disabled → Enabled privilege replacement

We currently only test that Enabled → Disabled is prevented

Tests are located in x-pack/platform/plugins/shared/features/server/feature_registry.test.ts

Contributor guide

Research direction
Examine the test file at x pack/platform/plugins/shared/features/server/feature registry.test.ts and add test cases for Disabled → Disabled and Disabled → Enabled privilege replacement scenarios.
Tech stack
typescript
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptTesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70