elastic/kibana

[Tags] Break with "&"

Open

#199143 opened on Nov 6, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Saved Object TaggingTeam:Corebuggood first issuequick-win

Description

Kibana version: 8.15.3 Elasticsearch version: 8.15.3

Describe the bug: The tags break and fail to show results due to ampersand "&"

Steps to reproduce:

  1. Create a tag
  2. Add string with & in between
  3. Search/click for the tag in Dashboards page
  4. Watch it return no results and issue error

Expected behavior: Tags should consider any values in the string value Screenshots (if relevant): Image

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Kibana tags featureBasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the tags feature in Kibana, focusing on how tag names are handled when they contain special characters like '&'. Examine the URL query parameters and the saved objects API requests for tag related operations. Look into the client side tag selection component, likely in the `plugins/saved objects tagging` or `plugins/dashboard` directory, to identify where the ampersand is not being properly encoded. The fix may involve applying encodeURIComponent when constructing URLs or when sending tag names to the backend.