elastic/kibana

[Management] Number fields accept invalid input

Open

#197506 opened on Oct 23, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)TypeScript (19,065 stars) (8,021 forks)batch import
Team:Kibana Managementbuggood first issue

Description

While testing https://github.com/elastic/kibana/pull/196527, I noticed that different form fields in Kibana Management plugins accept invalid input in number fields. Examples I noticed:

  • Ingest pipelines creation flow - add processor form
  • ILM creation flow

https://github.com/user-attachments/assets/6a883a7b-0cf4-43e2-bc36-c0ff6d2ebf1b

https://github.com/user-attachments/assets/45e21ff4-fc0d-4ef0-89c9-4dc922e1abfe

I think the e, -, and , characters are allowed by the Eui number field itself and it contains some validation for valid numbers. We should probably add validations from our side for valid numbers as well and not allow submitting the form if the number is invalid.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptEui components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the Ingest pipelines and ILM creation flows in Kibana Management plugins. Look at the EuiNumberField component's validation behavior. The issue references PR #196527; examine that PR for context. Since the issue has an assignee, coordinate with them before starting work. Focus on adding custom validation in form submission handlers to reject non numeric input.