elastic/kibana

A tab in Insights is active even if it's the only one

Open

#195958 opened on Oct 11, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)TypeScript (19,065 stars) (8,021 forks)batch import
9.1 candidateFeature:Cloud-SecurityTeam:Cloud Securitybuggood first issue

Description

Motivation

On Expanded flyout it might happen that only one of the current Insights tab is available, either Misconfigurations or Vulnerabilities. But even the tab is the only one it looks like it does smth as presented as enabled button. We need to either not show the tab or make it disable, consult with designers on this one

Image

Definition of done

  • Single tab should not mislead users into thinking that clicking on it does smth

Out of scope

Related tasks/epics

Team tag

@elastic/kibana-cloud-security-posture

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactKibana Insights tab codebaseConditional rendering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine the Insights flyout component to understand how tabs are rendered. Look for the code that determines which tabs are available. Consider implementing a conditional that hides or disables the tab when only one is present. Check any existing design guidelines or comments from designers for preferred approach.