elastic/kibana

[Deployment Management] Clean up @ts-expect-error failures from Typescript v4.9.5 upgrade

Open

#176244 opened on Feb 5, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Team:Kibana Managementchoregood first issue

Description

https://github.com/elastic/kibana/pull/175178 upgrades Typescript to v4.9.5. This leads to TS errors in plugins owned by the Management team. Failures are marked with @ts-expect-error. These need to be removed and have the typings fixed.

Full list of failures to follow up on:

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic TypeScript knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine each of the five files listed in the issue, specifically the lines where @ts expect error comments were added in PR #175178 (the TypeScript 4.9.5 upgrade). Understand the underlying TypeScript errors and fix them by correcting the typings or adjusting the code. Ensure the fix compiles without errors. The files are in x pack/plugins/index lifecycle management and src/plugins/es ui shared/static/forms/hook form lib.