elastic/kibana

[APM] Service icons metadata endpoint doesn't apply environment filter

Open

#175662 opened on Jan 26, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Team:obs-ux-infra_services - DEPRECATEDbuggood first issue

Description

We didn't consider the case where each environment could use different cloud provider or platform.

https://github.com/elastic/kibana/blob/beff74e19e94c7d3c609a2be0cb1d4b2f28da043/x-pack/plugins/apm/server/routes/services/route.ts#L282-L311

Contributor guide

Tech stack
typescriptnodejsrest api
Domain
backendapiobservability
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Elastic APMfamiliarity with Node.js/TypeScriptknowledge of environment filtering
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is in x pack/plugins/apm/server/routes/services/route.ts, specifically around lines 282-311, where the service icons metadata endpoint does not apply the environment filter. Investigate how other endpoints in the same file or other APM routes implement environment filtering. Look at the request handler and the service logic to determine where the filter should be added. Check if there are existing tests for this endpoint to understand expected behavior.