elastic/kibana

[telemetry] fetcher.validateConnectivity should wait for core ES service

Open

#171,888 opened on Nov 23, 2023

View on GitHub
 (1 comment) (1 reaction) (0 assignees)TypeScript (8,021 forks)batch import
Feature:TelemetryTeam:Coreenhancementgood first issue

Repository metrics

Stars
 (19,065 stars)
PR merge metrics
 (Avg merge 1d 16h) (999 merged PRs in 30d)

Description

Initial discussion here: https://github.com/elastic/kibana/pull/171713#pullrequestreview-1743923611

I wonder if we'd like to leverage the ES core service status as well (prob before setting up the timer, or merged). This way, if Kibana starts when ES is not available, it doesn't need to wait 12H to trigger the next connectivity check.

The telemetry connection check

https://github.com/elastic/kibana/blob/0b91e6db9b5fadcf2146ae8c174d3a3b49383239/src/plugins/telemetry/server/fetcher.ts#L98-L113

requires to fetch the telemetry config SO from the SO index. Therefore, the observable chain should ideally depend on the core ES service's status to only fetch when ES is up (and to try as soon as ES is up)

Contributor guide

Research direction
Investigate the telemetry fetcher's validateConnectivity method and the core ES service status observables. Determine how to wait for the ES service to be ready before performing the connectivity check, and implement the change in the observable chain.
Tech stack
typescriptnodejs
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Kibana development setupTypeScriptElasticsearch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60