elastic/kibana

[event log] unable to add properties named `meta` to event log doc schema

Open

#158,777 opened on May 31, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (8,021 forks)batch import
Feature:EventLogTeam:ResponseOpsbuggood first issue

Repository metrics

Stars
 (19,065 stars)
PR merge metrics
 (Avg merge 1d 16h) (999 merged PRs in 30d)

Description

See: https://github.com/elastic/kibana/blob/15b31c62ba8d4a115c359d9bb723147866bbd34c/x-pack/plugins/event_log/scripts/create_schemas.js#L189-L195

It appears the schema generator is looking for meta properties to determine if an ES field is considered an array. And that seems like some dead code, since we specifically call out "array" properties in our schema:

https://github.com/elastic/kibana/blob/15b31c62ba8d4a115c359d9bb723147866bbd34c/x-pack/plugins/event_log/scripts/mappings.js#L278-L285

Contributor guide

Research direction
Investigate the dead code path in create schemas.js that filters 'meta' properties and verify if it can be removed without affecting array detection.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75