elastic/kibana

[event log] unable to add properties named `meta` to event log doc schema

Open

#158777 opened on May 31, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:EventLogTeam:ResponseOpsbuggood first issue

Description

See: https://github.com/elastic/kibana/blob/15b31c62ba8d4a115c359d9bb723147866bbd34c/x-pack/plugins/event_log/scripts/create_schemas.js#L189-L195

It appears the schema generator is looking for meta properties to determine if an ES field is considered an array. And that seems like some dead code, since we specifically call out "array" properties in our schema:

https://github.com/elastic/kibana/blob/15b31c62ba8d4a115c359d9bb723147866bbd34c/x-pack/plugins/event_log/scripts/mappings.js#L278-L285

Contributor guide

Tech stack
typescriptnodejs
Domain
backenddata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Kibana event logbasic understanding of Elasticsearch mappings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is about the event log schema generation script at x pack/plugins/event log/scripts/create schemas.js, lines 189-195, which incorrectly checks for a 'meta' property to determine if a field is an array, while the mappings in mappings.js explicitly define array types. The fix should remove or update that dead code. No assignee or PR exists, so the issue is available for contribution.