elastic/kibana

[APM] Storage explorer should display sampling rate as N/A if there are no tx

Open

#150,302 opened on Feb 6, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Team:obs-ux-infra_services - DEPRECATEDapm:storage-explorerbuggood first issue

Description

Currently, the Storage Explorer displays a sampling rate of 0% if there are no transactions. This is misleading, as we can't actually infer what the sampling rate would be if there were transactions (which might not exist or might be dropped for whatever reason). We should instead display N/A. This would help the user (and us in the context of SDHs) establish more quickly that there are no transactions indexed into Elasticsearch.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/server/routes/storage_explorer/get_service_statistics.ts

Contributor guide

Tech stack
typescriptelasticsearch
Domain
observabilitybackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic TypeScriptKibana development setupAPM concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Examine the linked file `x pack/plugins/apm/server/routes/storage explorer/get service statistics.ts` to understand how the sampling rate is currently computed and returned. Check if there is a similar display logic in the frontend component that renders the Storage Explorer. The change likely involves returning a special string like 'N/A' when the number of transactions is zero or undefined. Ensure that the frontend can handle string values for sampling rate. Also consider any implications for sorting or filtering of the data table.