elastic/kibana

[Security Solution]: Import value lists retains even after user cancel importing the value list.

Open

#140056 opened on Sep 6, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Rule Value ListsTeam: SecuritySolutionTeam:Detection EngineTeam:Detections and Respbugeffort:lowgood first issueimpact:mediumvalue:medium

Description

Describe the bug: Import value lists retains even after user cancel importing the value list.

Build Details:

VERSION: 8.5.0-SNAPSHOT
BUILD: 55993
COMMIT: 436b2874794a6ffc05ad3b9ef28c298ff5384ca4

Preconditions

  1. Kibana should be running.

Steps to Reproduce

  1. Navigate to Alerts tab.
  2. Go to Rules tab.
  3. Now, click on import value lists.
  4. Select the file and click on import list.
  5. Now, cancel importing the file.
  6. Close the import value lists flyout and then again open the flyout.
  7. Observe that import value lists retains even after user cancel importing the value list.

Actual Result Import value lists retains even after user cancel importing the value list.

Expected Result Import value lists retains even after user cancel importing the value list.

Screen-Recording:

https://user-images.githubusercontent.com/84007952/188568558-31be3a9b-3958-4838-8b68-2067b69baaac.mp4

Contributor guide

Tech stack
typescriptreact
Domain
frontendsecurity
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The bug occurs in the import value lists flyout within the Security Solution's Rules tab. When a user cancels the import, the state of imported value lists persists unexpectedly. Investigate the component handling import state (likely a React component) in the security solution plugin. Check if the cancel action properly resets the imported data. The expected behavior is that canceling should clear the imported value lists. Look at the flyout's state management and ensure the cancel handler resets the relevant state.