elastic/kibana

[Task Manager] Clean up performance tests

Open

#117300 opened on Nov 3, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (19,065 stars) (8,021 forks)batch import
Feature:Task ManagerTeam:ResponseOpsestimate:smallgood first issuetechnical debt

Description

With https://github.com/elastic/kibana/pull/117294, we are removing the perf_hooks in task manager due to possible memory leakage. There is also a set of skipped functional tests in https://github.com/elastic/kibana/blob/main/x-pack/test/plugin_api_perf/test_suites/task_manager/index.ts that we should make sure to remove once we've confirmed that 🤞 removing the perf_hooks fixes the memory issue.

Contributor guide

Tech stack
typescriptnodejs
Domain
backendtestingperformance
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Kibana task managerContext from PR #117294
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
First, verify that PR #117294 has resolved the memory leak issue and is merged. Then, locate the file x pack/test/plugin api perf/test suites/task manager/index.ts in the Kibana repository. Remove the functional tests that are currently skipped (likely marked with `skip` or `xdescribe`). Ensure the tests are no longer needed and that no other parts of the codebase depend on them. Finally, submit a pull request to remove the skipped tests and any references to the old perf hooks usage if not already cleaned up.