elastic/elasticsearch

Share number based field mapper test code with other modules

Open

#92,947 opened on Jan 16, 2023

View on GitHub
 (17 comments) (2 reactions) (0 assignees)Java (76,700 stars) (25,882 forks)batch import
:Search Foundations/Mapping>testTeam:Search Foundationsgood first issue

Description

Move number based field mapper test infrastructure to the test framework module. This would allow other number based field mapper to use the same test infrastructure that the core number field mappers are using.

Currently UnsignedLongFieldMapper and ScaledFloatFieldMapper have their own concrete tests, but could instead make use of NumberFieldMapperTests or WholeNumberFieldMapperTests. This avoids duplicates tests and testing logic.

Furthermore this can avoid that non core field mappers don't get forgotten when new features / behaviour is added to core field mappers.

Originates from #92917

Contributor guide

Tech stack
java
Domain
testing
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaElasticsearch test infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the existing NumberFieldMapperTests and WholeNumberFieldMapperTests in the core module to understand the test infrastructure. Also examine UnsignedLongFieldMapper and ScaledFloatFieldMapper tests to see current duplication. The proposed refactoring aims to move shared test utilities to the test framework module. Refer to issue #92917 for further context.